[BUGFIX release] Fix Embroider compatibility with ember-source@3.27.2+ #19586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No logical changes here, just moving the code to detect and generate the message out into a stand alone module (makes it easier to reason about and possible to unit test). Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
Fixes a few things: * Ensures that Embroider has a consistent protocol for ensuring the global is bootstrapped * Allows our override code to be transpiled * Ensures that any bootstrapping tweaks force us out of "prebuilt" mode (allowing that customized bootstrap code to actually run) Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
chancancode
force-pushed
the
refactor-global-deprecation-override
branch
from
e59ee30
to
d0e64ac
Compare
chancancode
force-pushed
the
refactor-global-deprecation-override
branch
from
d0e64ac
to
6c36fff
Compare
Also fixed a few minor errors in the message (wrong version number etc) Included a list of hardcoded known dormant addons (polyfills mostly) to make the suggestions more reliable.
chancancode
force-pushed
the
refactor-global-deprecation-override
branch
from
6c36fff
to
35689f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few things:
Refactors the work in #19557 to address some of the recent comments there.