[DONT BACKPORT][BUGFIX release] Makes the (hash) helper lazy #19511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the hash helper's individual keys lazy so that they do not eagerly incur costs.
pzuraq
force-pushed
the
bugfix/update-vm-lazy-hash
branch
from
f9d7bf6
to
7d334cf
Compare
krisselden
approved these changes
May 12, 2021
pzuraq
changed the title
pzuraq
pushed a commit
that referenced
this pull request
May 12, 2021
Backports the fixes from #19511 The internal `_query` property of LinkTo had to be made into an autotracking dependency using dependentKeyCompat in order to handle the fact that hash never updates now. This was not an issue on master since LinkTo has been refactored there.
pzuraq
changed the title
pzuraq
changed the title
pzuraq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the hash helper's individual keys lazy so that they do not eagerly
incur costs. See this PR for more details: glimmerjs/glimmer-vm#1298
This PR/fix ended up not working out, so we're not backporting