[BUGFIX lts] Backport {{hash}} laziness #19543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports the fixes from #19511 The internal `_query` property of LinkTo had to be made into an autotracking dependency using dependentKeyCompat in order to handle the fact that hash never updates now. This was not an issue on master since LinkTo has been refactored there.
|
@pzuraq - Where are we at with this? |
|
The PR needs to be updated to add the additional fixes that landed recently. I was planning on updating it once we landed those in release and were pretty sure it wouldn't need any more changes. |
|
At this point, we're clearly not backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the fixes from #19511
The internal
_queryproperty of LinkTo had to be made into an autotrackingdependency using dependentKeyCompat in order to handle the fact
that hash never updates now. This was not an issue on master since
LinkTo has been refactored there.