Remove CLI option --json
#2193
Merged
Remove CLI option --json
#2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
remove-json-option-cli
branch
from
8220ef2
to
ac2cff3
Compare
bmish
commented
Nov 17, 2021
| @@ -265,7 +260,7 @@ function printPending(results, options) { | |||
| } | |||
| let pendingListString = JSON.stringify(pendingList, null, 2); | |||
|
|
|||
| if (options.json) { | |||
| if (options.format === 'json') { | |||
There was a problem hiding this comment.
This is a bug fix. Previously, --print-pending only worked with --json but not --format=json.
There was a problem hiding this comment.
Extracting the fix to master: #2210
Although it turns out both --json and --print-pending will be removed in v4.
scalvert
approved these changes
Nov 17, 2021
ksrb
pushed a commit
to ksrb/intellij-emberjs-experimental
that referenced
this pull request
Apr 25, 2022
patricklx
pushed a commit
to patricklx/intellij-emberjs-experimental
that referenced
this pull request
Apr 27, 2022
See ember-template-lint/ember-template-lint#2193 Co-authored-by: Kevin Suen <ksuen@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the deprecation of this option in #1907.
Use
--format=jsoninstead.Part of v4 release (#1908).