Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memoize existsSync calls on the fastboot instance itself #666

Merged
merged 1 commit into from Mar 3, 2019
Merged

memoize existsSync calls on the fastboot instance itself #666

merged 1 commit into from Mar 3, 2019

Commits on Mar 2, 2019

  1. memoize existsSync calls on the fastboot instance itself 

    In large applications with many nested addons and engines, this can do
excessive work.

Luckily it is perfectly consistent for us to cache this on the addon
instance state. In-fact it is incoherent for this to change from the
perspective of one fastboot addon instance
    @stefanpenner
    stefanpenner committed Mar 2, 2019
    Copy the full SHA
    aac6fe5 View commit details
    Browse the repository at this point in the history