memoize existsSync calls on the fastboot instance itself #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In large applications with many nested addons and engines, this can do excessive work. Luckily it is perfectly consistent for us to cache this on the addon instance state. In-fact it is incoherent for this to change from the perspective of one fastboot addon instance
rwjblue
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large applications with many nested addons and engines, this can do
excessive work.
Luckily it is perfectly consistent for us to cache this on the addon
instance state. In-fact it is incoherent for this to change from the
perspective of one fastboot addon instance