Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-invalid-debug-function-arguments: Use dynamic error message #365

Merged
merged 1 commit into from Dec 29, 2018
Merged

no-invalid-debug-function-arguments: Use dynamic error message #365

merged 1 commit into from Dec 29, 2018

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 29, 2018 •
edited

Error message (before):

Usage of Ember's `assert` / `warn` / `deprecate` function has its arguments passed in the wrong order. `String description` should come before `Boolean condition`."

Error message (after):

Usage of Ember's `assert` function has its arguments passed in the wrong order. `String description` should come before `Boolean condition`."

Requested by @Turbo87: #364 (comment)

@bmish bmish mentioned this pull request Dec 29, 2018
Merged
Turbo87
Turbo87 approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Turbo87 Turbo87 merged commit c590737 into ember-cli:master Dec 29, 2018
@Turbo87 Turbo87 changed the title feat: use dynamic error message for 'no-invalid-debug-function-arguments' rule. no-invalid-debug-function-arguments: Use dynamic error message Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @Turbo87