assert-arg-order: Rename to no-invalid-debug-function-arguments and detect invalid usages of deprecate and warn too
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 27, 2018
bmish
changed the title
|
@rwjblue good idea, I renamed the rule to |
bmish
changed the title
Turbo87
reviewed
Dec 28, 2018
|
|
||
| assert(label, 'Label must be present.'); | ||
| warn(label, 'Label must be present.'); | ||
| deprecate(title, 'Title is no longer supported.'); |
There was a problem hiding this comment.
@bmish I think deprecate() is supposed to always have a third argument (an options hash).
There was a problem hiding this comment.
Good point, added the third argument to both warn and deprecate.
…guments' to also detect invalid usages of 'deprecate' and 'warn'.
Turbo87
approved these changes
Dec 29, 2018
|
thanks again @bmish! one small potential improvement would be to not show the generic error message, but instead, show an error message mentioning the debug function that you actually used. |
Turbo87
changed the title
Turbo87
changed the title
no-invalid-debug-function-arguments and detect invalid usages of deprecate and warn too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
assert-arg-orderrule tono-invalid-debug-function-arguments. Generalizes it to detect theassertargument order mistake along with two other similar functions (deprecateandwarn).Requested by @Turbo87.