Merge pull request #935 from bmish/spread-syntax-tests

Add some more spread syntax tests
ember-cli · Sep 7, 2020 · 4768303 · 4768303
2 parents 670726c + f4f7af2
commit 4768303
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/tests/lib/rules/classic-decorator-hooks.js b/tests/lib/rules/classic-decorator-hooks.js
@@ -19,7 +19,8 @@ ruleTester.run('classic-decorator-hooks', rule, {
     `
       const Foo = EmberObject.extend({
         init() {},
-        destroy() {}
+        destroy() {},
+        ...foo
       })
     `,
     `

diff --git a/tests/lib/rules/new-module-imports.js b/tests/lib/rules/new-module-imports.js
@@ -9,7 +9,9 @@ const RuleTester = require('eslint').RuleTester;
 // Tests
 // ------------------------------------------------------------------------------
 
-const eslintTester = new RuleTester();
+const eslintTester = new RuleTester({
+  parser: require.resolve('babel-eslint'),
+});
 eslintTester.run('new-module-imports', rule, {
   valid: [
     {
@@ -37,7 +39,8 @@ eslintTester.run('new-module-imports', rule, {
         import { bool } from '@ember/object/computed';
 
         export default Controller.extend({
-          isTrue: bool('')
+          isTrue: bool(''),
+          ...foo
         });
       `,
       parserOptions: { ecmaVersion: 6, sourceType: 'module' },

diff --git a/tests/lib/rules/no-attrs-snapshot.js b/tests/lib/rules/no-attrs-snapshot.js
@@ -4,6 +4,7 @@ const RuleTester = require('eslint').RuleTester;
 const { ERROR_MESSAGE } = rule;
 const eslintTester = new RuleTester({
   parserOptions: { ecmaVersion: 6, sourceType: 'module' },
+  parser: require.resolve('babel-eslint'),
 });
 
 eslintTester.run('no-attrs-snapshot', rule, {
@@ -22,7 +23,8 @@ eslintTester.run('no-attrs-snapshot', rule, {
             } else {
               this.set('updated', false);
             }
-          }
+          },
+          ...foo
         });`,
     `
         export default Ember.Component({

diff --git a/tests/lib/rules/no-unnecessary-service-injection-argument.js b/tests/lib/rules/no-unnecessary-service-injection-argument.js
@@ -16,6 +16,7 @@ const ruleTester = new RuleTester({
     ecmaVersion: 2015,
     sourceType: 'module',
   },
+  parser: require.resolve('babel-eslint'),
 });
 
 ruleTester.run('no-unnecessary-service-injection-argument', rule, {
@@ -99,6 +100,8 @@ ruleTester.run('no-unnecessary-service-injection-argument', rule, {
         ecmaFeatures: { legacyDecorators: true },
       },
     },
+
+    'export default Component.extend({ ...foo });',
   ],
   invalid: [
     // `Component` examples:

diff --git a/tests/lib/rules/use-ember-data-rfc-395-imports.js b/tests/lib/rules/use-ember-data-rfc-395-imports.js
@@ -15,14 +15,15 @@ const { ERROR_MESSAGE: message } = rule;
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester({ parserOptions });
+const ruleTester = new RuleTester({ parserOptions, parser: require.resolve('babel-eslint') });
 ruleTester.run('use-ember-data-rfc-395-imports', rule, {
   valid: [
     "import Model from '@ember-data/model';",
     `import Model, { attr } from '@ember-data';
 
      export default Model.extend({
-       name: attr('string')
+       name: attr('string'),
+       ...foo
      });
     `,
     `import LOL from 'who-knows-but-definitely-not-ember-data';
@@ -43,6 +44,7 @@ ruleTester.run('use-ember-data-rfc-395-imports', rule, {
       code: `import DS from 'ember-data';
 
         export default DS.Model.extend({
+          ...foo
         });
       `,
       output: null,