Merge pull request #933 from bmish/routes-segments-snake-case-fix-spread

Fix spread syntax crash in `routes-segments-snake-case` rule
ember-cli · Sep 7, 2020 · 670726c · 670726c
2 parents e3746be + 4efe5b9
commit 670726c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/rules/routes-segments-snake-case.js b/lib/rules/routes-segments-snake-case.js
@@ -31,7 +31,12 @@ module.exports = {
     };
 
     const isSegment = function (property) {
-      return property.key.name === 'path' && routeSegmentRegex.test(property.value.value);
+      return (
+        types.isProperty(property) &&
+        types.isIdentifier(property.key) &&
+        property.key.name === 'path' &&
+        routeSegmentRegex.test(property.value.value)
+      );
     };
 
     const getSegmentNames = function (property) {

diff --git a/tests/lib/rules/routes-segments-snake-case.js b/tests/lib/rules/routes-segments-snake-case.js
@@ -9,7 +9,7 @@ const RuleTester = require('eslint').RuleTester;
 // Tests
 // ------------------------------------------------------------------------------
 
-const eslintTester = new RuleTester();
+const eslintTester = new RuleTester({ parser: require.resolve('babel-eslint') });
 eslintTester.run('routes-segments-snake-case', rule, {
   valid: [
     'this.route("tree", { path: ":tree_id"});',
@@ -26,6 +26,7 @@ eslintTester.run('routes-segments-snake-case', rule, {
     'this.route("tree", { path: "/test/:tree_id/test-test/:tree_child_id"});',
     'this.route("tree", { path: "/test/:tree_id/testTest/:tree_child_id"});',
     'this.route("tree", { path: "*:"});',
+    'this.route("tree", { ...foo });',
   ],
   invalid: [
     {