fix(glimmer-wrapper): add normalize method for Registry#has

[buschtoens]

Fixes #299.

[buschtoens]

@mixonic #195 (comment):

Doing this in Ember's current service injection system is tricky since the injections are part of metal but dasherize etc are not. I punted and simply implemented in this repo for now.

tbh, I think we should still try to land that fix upstream. Doing it in here is really brittle.

keyName would need dasherization here: https://github.com/emberjs/ember.js/blob/f96a8df934fc8b4178f587b1cce609df15930922/packages/%40ember/-internals/metal/lib/injected_property.ts#L70

[lolmaus]

🙇

[buschtoens]

This seems to be broken. Resolver#normalize is null even though the following is included in the build:

  if (true) {
    Resolver.prototype.normalize = function (specifier) {
      // This method is called by `Registry#validateInjections` in dev mode.
      // https://github.com/ember-cli/ember-resolver/issues/299
      const [type, name] = specifier.split(':', 2);
      if (name && (type === 'service' || type === 'controller')) {
        return `${type}:${Ember.String.dasherize(name)}`;
      }
      return specifier;
    };
  }

I assume that this is because Ember manually collapses the prototype and normalize: null somehow takes precedence.

What is your suggested solution? Use .reopen({ ... }) or use a ternary in the original .extend({ ... }) block? I'm leaning towards a ternary like:

const Resolver = GlobalsResolver.extend({
  // ...

  normalize: !DEBUG ? null : function(specifier) {
    // This method is called by `Registry#validateInjections` in dev mode.
    // https://github.com/ember-cli/ember-resolver/issues/299
    const [type, name] = specifier.split(':', 2);
    if (name && (type === 'service' || type === 'controller')) {
      return `${type}:${dasherize(name)}`;
    }
    return specifier;
  },

  // ...
});

I assume constant ternaries are also optimized away by ember-cli-uglify / terser?

[buschtoens]

Just tested the above fix in our app. It works. I'll send another PR.