fix(glimmer-wrapper): move debug normalize in .extend() block

[buschtoens]

#300 (comment)

This seems to be broken. Resolver#normalize is null even though the following is included in the build:

  if (true) {
    Resolver.prototype.normalize = function (specifier) {
      // This method is called by `Registry#validateInjections` in dev mode.
      // https://github.com/ember-cli/ember-resolver/issues/299
      const [type, name] = specifier.split(':', 2);
      if (name && (type === 'service' || type === 'controller')) {
        return `${type}:${Ember.String.dasherize(name)}`;
      }
      return specifier;
    };
  }

I assume that this is because Ember manually collapses the prototype and normalize: null somehow takes precedence.

What is your suggested solution? Use .reopen({ ... }) or use a ternary in the original .extend({ ... }) block? I'm leaning towards a ternary like:

const Resolver = GlobalsResolver.extend({
  // ...

  normalize: !DEBUG ? null : function(specifier) {
    // This method is called by `Registry#validateInjections` in dev mode.
    // https://github.com/ember-cli/ember-resolver/issues/299
    const [type, name] = specifier.split(':', 2);
    if (name && (type === 'service' || type === 'controller')) {
      return `${type}:${dasherize(name)}`;
    }
    return specifier;
  },

  // ...
});

I assume constant ternaries are also optimized away by ember-cli-uglify / terser?

[rwjblue]

This is failing CI due to linting errors, I left an inline comment that might work but I'm also fine with disabling that lint rule inline...

[rwjblue]

Can you hoist this above? Something like:

const normalize = !DEBUG ? null : function normalize(specifier) {
  // ...snip...
};

GlobalsResolver.extend({
  // ...snip...
  normalize,
});

[buschtoens]

Done 👍