New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Upgrade ESLint to v8 in app
and addon
blueprints
#9669
Changes from 11 commits
e97c6ad
b5cbf22
8ae8d5f
452de3e
b7bf47c
dd6e1f8
799e8cd
2af5e8a
698cce5
577f0dc
ff2cd30
71e85f5
2e93783
11d6dd1
ad4ae4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ | |
"test:ember": "ember test" | ||
bertdeblock marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
"devDependencies": { | ||
"@babel/eslint-parser": "^7.15.8", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there a way we can bundle these dependencies as fallbacks? so we don't have to bundle them in the app's package.json? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is! I found a way There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bug (blocking) Before, Pseudocode:
I listed the latest versions above, in case you want the latest. |
||
"@babel/plugin-proposal-decorators": "^7.15.8", | ||
"@ember/optional-features": "^2.0.0", | ||
"@ember/test-helpers": "^2.8.1<% if (embroider) { %>", | ||
"@embroider/compat": "^1.9.0", | ||
|
@@ -32,8 +34,7 @@ | |
"@glimmer/component": "^1.1.2", | ||
"@glimmer/tracking": "^1.1.2<% if (typescript) { %>", | ||
"@typescript-eslint/eslint-plugin": "^5.40.1", | ||
"@typescript-eslint/parser": "^5.40.1<% } else { %>", | ||
"babel-eslint": "^10.1.0<% } %>", | ||
"@typescript-eslint/parser": "^5.40.1<% } %>", | ||
"broccoli-asset-rev": "^3.0.0", | ||
"concurrently": "^7.4.0", | ||
"ember-auto-import": "^2.4.3", | ||
|
@@ -54,7 +55,7 @@ | |
"ember-source": "~4.9.0-beta.1", | ||
"ember-template-lint": "^4.16.1<% if (welcome) { %>", | ||
"ember-welcome-page": "^6.2.0<% } %>", | ||
"eslint": "^7.32.0", | ||
"eslint": "^8.24.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latest version is (We can always create a separate PR to update |
||
"eslint-config-prettier": "^8.5.0", | ||
"eslint-plugin-ember": "^11.1.0", | ||
"eslint-plugin-n": "^15.4.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
Now that
@babel/plugin-proposal-decorators
is used, I don't think we need theecmaFeatures
key (along withlegacyDecorators
) anymore (lines 9-11)?The first commit (e97c6ad) shows that
ecmaFeatures
had been removed. I wonder if it got accidentally re-introduced by mergingmaster
(i.e. a rebase didn't happen correctly).