[ENHANCEMENT] Upgrade ESLint to v8 in `app` and `addon` blueprints #9669

nightire · 2021-10-18T11:00:45Z

babel-eslint does not works well with eslint@8, this PR uses @babel/eslint-parser instead.

The failing tests are not related with changes in this PR.

It's required to use `@babel/plugin-proposal-decorators` plugin with `@babel/eslint-parser` if we want to support decorators in JavaScript. This reverts commit 8ae8d5f.

SergeAstapov · 2021-10-18T20:57:54Z

@nightire I assume this is similar to #9556 and last comment from @rwjblue in #9556 is that we need an RFC for such a change.

cc @bmish as you worked originally on #9556.

I can volunteer to start an RFC to the extent my tech writing allows me to do, just to start the bowl rolling

nightire · 2021-10-19T03:02:14Z

@SergeAstapov that would be awesome, thank you.

miguelcobain · 2021-12-03T02:32:05Z

ember-auto-import doesn't seem happy with useBabelConfig: true: embroider-build/ember-auto-import#471

NullVoxPopuli · 2022-01-06T02:32:36Z

blueprints/app/files/package.json

@@ -23,14 +23,15 @@
    "test:ember": "ember test"
  },
  "devDependencies": {
+    "@babel/eslint-parser": "^7.15.8",


is there a way we can bundle these dependencies as fallbacks? so we don't have to bundle them in the app's package.json?

There is! I found a way

Upgrading it seems to break stuff with babel-parser. See: * ember-cli/ember-cli#9307 * ember-cli/ember-cli#9669

bertdeblock · 2022-04-29T07:20:17Z

Opened emberjs/rfcs#817 to hopefully get the ball rolling on this one.

Get rid of deprecated `babel-eslint` References: ember-cli/ember-cli#9669 ijlee2/ember-container-query#115

ef4 · 2022-07-06T17:23:08Z

I don't think upgrading the parser like this needs an RFC.

However, my main concern is that this hard-codes a separate babel config for use by eslint that needs to be maintained separately from the real config. That might be an acceptable tradeoff given that it will be more difficult for many apps to quickly adopt a standalone babel config file.

wagenet · 2022-07-23T02:50:59Z

@ef4 what would it take for you to feel comfortable landing this?

jelhan · 2022-10-04T12:23:00Z

What is the status here? Would be great if we could upgrade to eslint v8 in Ember projects. In general migration from babel-eslint to @babel/eslint-parser seems to desirable on its own as well was babel-eslint is deprecated since a long-time.

bertdeblock · 2022-10-04T15:50:28Z

I would like to see this progress as well. I'll try to update the PR and put this on the agenda for the CLI meeting tomorrow.

SergeAstapov · 2022-10-04T16:05:01Z

@bertdeblock thanks for helping with this! If RFC still needed, I can help with it as called out before however there were several comments here and there it may not be needed.

bmish · 2022-10-04T16:10:26Z

I agree it's important to get this ESLint / @babel/eslint-parser upgrade in.

Last I saw, it was stalled on comments on this PR / my previous PR attempt (#9556).

Note that Ember already works fine with these upgraded versions, they just don't come standard in the Ember blueprint yet.

blueprints/app/files/package.json

bertdeblock · 2022-10-04T21:53:11Z

tests/fixtures/addon/defaults-travis/package.json

    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-ember": "^10.4.2",
+    "eslint-plugin-ember": "^10.5.4",


Seems outdated, don't think this version should be touched for this PR?

ef4 · 2022-10-05T17:19:05Z

While I still don't love having a separate babel config in the eslintrc, I think it's the closest way to configure the existing behavior in the new version. So I'm ok with it.

ijlee2 · 2022-12-01T19:12:02Z

Hello, I think it'd be good for us to resume working on this pull request and getting it merged soon.

To provide confidence to this PR: I was able to migrate a monorepo with addons and engines to use eslint@v8.28 (with a mix of @babel/eslint-parser and @typescript-eslint/parser, as well as using eslint-plugin-n instead of eslint-plugin-node). I would like to see an official support of eslint@v8 in the blueprints.

Going forward, eslint will ask for a flat configuration. We'll also want to work together on updating eslint-plugin-ember to be compatible with the new format.

PS. In eslint/eslint#13481, how can we get eslint-plugin-ember listed under Phase 3: Compatibility testing to raise awareness?

bmish · 2022-12-01T20:34:19Z

PS. In eslint/eslint#13481, how can we get eslint-plugin-ember listed under Phase 3: Compatibility testing to raise awareness?

I don't think we need the ESLint team to monitor compatibility with eslint-plugin-ember. They just listed a few top ESLint plugins in that section as a sanity check that their flat config implementation works properly. But it would be good to file an issue in eslint-plugin-ember for us to add support for flat config.

bmish · 2022-12-01T21:09:29Z

@nightire can you merge the latest master into this PR? As @ef4 said, I think it's time we proceed with this PR, even if we're not perfectly happy with the separate babel config inside the ESLint config. We can adjust that setup later, but it's important we get ESLint updated now.

NullVoxPopuli · 2022-12-02T04:42:15Z

For reference, i have a flat config here: embroider-build/addon-blueprint#71

nightire · 2022-12-03T04:16:19Z

@nightire can you merge the latest master into this PR? As @ef4 said, I think it's time we proceed with this PR, even if we're not perfectly happy with the separate babel config inside the ESLint config. We can adjust that setup later, but it's important we get ESLint updated now.

@bmish Done.

bmish · 2022-12-03T06:06:19Z

tests/fixtures/app/yarn-travis/package.json

    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-ember": "^10.4.2",
+    "eslint-plugin-ember": "^10.5.4",


This doesn't seem to be properly rebased. This is an older version than is on master:

ember-cli/blueprints/app/files/package.json

Line 59 in 1e415ad

"eslint-plugin-ember": "^11.1.0",

With a few searches and replace, all occurrences are now updated to the ^11.10.

bertdeblock · 2022-12-03T08:15:18Z

The parser in the ESLint config file is still babel-eslint and babel-eslint is still included in package.json. Note that we now also need to take the typescript flag into account, because ts projects use a different parser + parser options.

bmish · 2022-12-03T15:26:57Z

Can you search for "eslint" to make sure that it's bumped to the same v8 version everywhere? There are still fixtures it hasn't been updated in.

bmish · 2022-12-03T15:29:00Z

As mentioned by @bertdeblock, I still see babel-eslint in a bunch of places.

ijlee2 · 2022-12-04T12:52:31Z

blueprints/app/files/package.json

@@ -24,6 +24,8 @@
    "test:ember": "ember test"
  },
  "devDependencies": {
+    "@babel/eslint-parser": "^7.15.8",


bug (blocking)

Before, babel-eslint was added to package.json via the else clause. You'll want to add @babel/eslint-parser and @babel/plugin-proposal-decorators conditionally.

Pseudocode:

<% if (!typescript) { %> "@babel/eslint-parser": "^7.19.1", "@babel/plugin-proposal-decorators": "^7.20.5", <% } %>

I listed the latest versions above, in case you want the latest.

ijlee2 · 2022-12-04T12:55:13Z

blueprints/app/files/package.json

@@ -54,7 +55,7 @@
    "ember-source": "~4.9.0-beta.1",
    "ember-template-lint": "^4.16.1<% if (welcome) { %>",
    "ember-welcome-page": "^6.2.0<% } %>",
-    "eslint": "^7.32.0",
+    "eslint": "^8.24.0",


The latest version is 8.29.0, in case you want the latest.

(We can always create a separate PR to update eslint and its plugins to the latest.)

ijlee2 · 2022-12-04T13:09:05Z

blueprints/app/files/.eslintrc.js

+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],


question

Now that @babel/plugin-proposal-decorators is used, I don't think we need the ecmaFeatures key (along with legacyDecorators) anymore (lines 9-11)?

The first commit (e97c6ad) shows that ecmaFeatures had been removed. I wonder if it got accidentally re-introduced by merging master (i.e. a rebase didn't happen correctly).

bertdeblock · 2022-12-05T08:39:15Z

package.json

@@ -143,7 +143,7 @@
    "chai-jest-snapshot": "^2.0.0",
    "ember-cli-blueprint-test-helpers": "^0.19.2",
    "ember-cli-internal-test-helpers": "^0.9.1",
-    "eslint": "^8.24.0",
+    "eslint": "^8.29.0",


Bumping eslint for ember-cli itself can be omitted from this PR imo, as it's not related to the blueprints.

bertdeblock · 2022-12-05T08:41:32Z

blueprints/app/files/package.json

@@ -24,6 +24,8 @@
    "test:ember": "ember test"
  },
  "devDependencies": {
+    <% if (!typescript) { %>"@babel/eslint-parser": "^7.19.1",


I think the file should still be valid JSON, see #10058 for more info.

@bertdeblock Do you have the permissions to run CI? It'd help @nightire to see if linting and testing are passing. (For first-time contributors, I'm not sure if you may need to approve running workflows after every push.)

Approved, but it's failing because eslint was bumped in ember-cli's package file without updating the lock file.
I would omit that bump from this PR though.

nightire added 4 commits October 18, 2021 18:56

upgrade eslint to v8 in blueprints

e97c6ad

update test fixtures for eslint v8

b5cbf22

remove @babel/plugin-proposal-decorators

8ae8d5f

Revert "remove @babel/plugin-proposal-decorators"

452de3e

It's required to use `@babel/plugin-proposal-decorators` plugin with `@babel/eslint-parser` if we want to support decorators in JavaScript. This reverts commit 8ae8d5f.

This was referenced Oct 19, 2021

Update eslint to v8 in blueprint #9668

Closed

ESLint throws "Must use import to load ES Module..." ember-cli/eslint-plugin-ember#1346

Closed

ctjhoa mentioned this pull request Nov 4, 2021

Replace deprecated babel-eslint with new @babel/eslint-parser #9307

Closed

NullVoxPopuli reviewed Jan 6, 2022

View reviewed changes

jacobq added a commit to jacobq/repro-ember-drag-drop-on-ember4-embroider-app that referenced this pull request Feb 28, 2022

fix: downgrade eslint 8->7

26ac03b

Upgrading it seems to break stuff with babel-parser. See: * ember-cli/ember-cli#9307 * ember-cli/ember-cli#9669

bertdeblock mentioned this pull request Apr 29, 2022

Replace babel-eslint with @babel/eslint-parser in blueprints emberjs/rfcs#817

Closed

ijlee2 mentioned this pull request May 7, 2022

Updated eslint to v8 ijlee2/ember-container-query#115

Merged

andreyfel added a commit to retailnext/ember-bem-helpers that referenced this pull request May 18, 2022

Update eslint to v8

aee7453

Get rid of deprecated `babel-eslint` References: ember-cli/ember-cli#9669 ijlee2/ember-container-query#115

andreyfel mentioned this pull request May 18, 2022

Update eslint to v8 retailnext/ember-bem-helpers#35

Merged

jelhan mentioned this pull request Oct 4, 2022

Update dependency eslint to v8 - autoclosed jelhan/ember-style-modifier#61

Closed

1 task

Merge branch 'master' into nightire/upgrade-eslint

b7bf47c

bertdeblock reviewed Oct 4, 2022

View reviewed changes

nightire added 2 commits October 5, 2022 06:05

Do not touch irrelevant dependencies

dd6e1f8

Bump up eslint & remove babel-eslint

799e8cd

bertdeblock added the enhancement label Oct 5, 2022

bertdeblock changed the title ~~upgrade eslint to v8~~ [ENHANCEMENT] Upgrade ESLint to v8 in app and addon blueprints Oct 5, 2022

bertdeblock self-assigned this Oct 5, 2022

Merge branch 'master' into nightire/upgrade-eslint

2af5e8a

bmish reviewed Dec 3, 2022

View reviewed changes

nightire force-pushed the nightire/upgrade-eslint branch from 5b623b6 to 2af5e8a Compare December 3, 2022 06:34

nightire added 2 commits December 3, 2022 14:56

Merge branch 'master' into nightire/upgrade-eslint

698cce5

Bump up eslint-plugin-ember to v11.1.0

577f0dc

Remove all babel-eslint deps

ff2cd30

ijlee2 reviewed Dec 4, 2022

View reviewed changes

nightire added 3 commits December 5, 2022 15:23

Update all eslint to v8.29.0

71e85f5

Remove unused ecmaFeatures

2e93783

Install babel eslint parser conditionally

11d6dd1

bertdeblock reviewed Dec 5, 2022

View reviewed changes

Ensure json still be valid when using condition clause

ad4ae4c

ursm mentioned this pull request Jan 17, 2023

Bump eslint from 7.32.0 to 8.32.0 in /frontend ddbj/submission-mss#31

Closed

bertdeblock mentioned this pull request Jan 28, 2023

[ENHANCEMENT] Update ESLint to v8 in app and addon blueprints #10142

Merged

bertdeblock closed this in #10142 Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENHANCEMENT] Upgrade ESLint to v8 in `app` and `addon` blueprints #9669

[ENHANCEMENT] Upgrade ESLint to v8 in `app` and `addon` blueprints #9669

nightire commented Oct 18, 2021 •

edited

SergeAstapov commented Oct 18, 2021

nightire commented Oct 19, 2021

miguelcobain commented Dec 3, 2021

NullVoxPopuli Jan 6, 2022

runspired Jan 6, 2022

NullVoxPopuli Dec 2, 2022

bertdeblock commented Apr 29, 2022

ef4 commented Jul 6, 2022

wagenet commented Jul 23, 2022

jelhan commented Oct 4, 2022

bertdeblock commented Oct 4, 2022

SergeAstapov commented Oct 4, 2022

bmish commented Oct 4, 2022

bertdeblock Oct 4, 2022

ef4 commented Oct 5, 2022

ijlee2 commented Dec 1, 2022

bmish commented Dec 1, 2022

bmish commented Dec 1, 2022

NullVoxPopuli commented Dec 2, 2022

nightire commented Dec 3, 2022

bmish Dec 3, 2022

nightire Dec 3, 2022

bertdeblock commented Dec 3, 2022

bmish commented Dec 3, 2022

bmish commented Dec 3, 2022 •

edited

ijlee2 Dec 4, 2022 •

edited

ijlee2 Dec 4, 2022 •

edited

ijlee2 Dec 4, 2022

bertdeblock Dec 5, 2022

bertdeblock Dec 5, 2022

ijlee2 Dec 5, 2022

bertdeblock Dec 5, 2022

		plugins: [
		['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],

[ENHANCEMENT] Upgrade ESLint to v8 in app and addon blueprints #9669

[ENHANCEMENT] Upgrade ESLint to v8 in app and addon blueprints #9669

Conversation

nightire commented Oct 18, 2021 • edited

SergeAstapov commented Oct 18, 2021

nightire commented Oct 19, 2021

miguelcobain commented Dec 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bertdeblock commented Apr 29, 2022

ef4 commented Jul 6, 2022

wagenet commented Jul 23, 2022

jelhan commented Oct 4, 2022

bertdeblock commented Oct 4, 2022

SergeAstapov commented Oct 4, 2022

bmish commented Oct 4, 2022

Choose a reason for hiding this comment

ef4 commented Oct 5, 2022

ijlee2 commented Dec 1, 2022

bmish commented Dec 1, 2022

bmish commented Dec 1, 2022

NullVoxPopuli commented Dec 2, 2022

nightire commented Dec 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bertdeblock commented Dec 3, 2022

bmish commented Dec 3, 2022

bmish commented Dec 3, 2022 • edited

ijlee2 Dec 4, 2022 • edited

Choose a reason for hiding this comment

ijlee2 Dec 4, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

[ENHANCEMENT] Upgrade ESLint to v8 in `app` and `addon` blueprints #9669

[ENHANCEMENT] Upgrade ESLint to v8 in `app` and `addon` blueprints #9669

nightire commented Oct 18, 2021 •

edited

bmish commented Dec 3, 2022 •

edited

ijlee2 Dec 4, 2022 •

edited

ijlee2 Dec 4, 2022 •

edited