Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment on the environment.js blueprint files #8434

Merged
merged 1 commit into from Feb 16, 2019
Merged

Fix comment on the environment.js blueprint files #8434

merged 1 commit into from Feb 16, 2019

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Feb 14, 2019

The PR is a missing detail that should have been included at #8433.

Thanks, @NullVoxPopuli for the notice.

@ppcano ppcano mentioned this pull request Feb 14, 2019
Merged
@ppcano ppcano closed this Feb 14, 2019
@ppcano ppcano reopened this Feb 14, 2019
rwjblue
rwjblue approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I remember when with-controller feature was being developed. Good times.

@rwjblue rwjblue merged commit 30314ab into ember-cli:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppcano @rwjblue