Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints: Update dependencies #8396

Merged
merged 1 commit into from Mar 16, 2019
Merged

blueprints: Update dependencies #8396

merged 1 commit into from Mar 16, 2019

Conversation

mistahenry
Copy link

Fixes 8395

@Turbo87
Copy link
Member

Turbo87 commented Feb 6, 2019

looks like some update in this PR is failing CI. might be related to #8080 also not passing.

@mistahenry
Copy link
Author

@Turbo87 I just verified that the problem exists on the beta branch before any of my changes are applied.

@Turbo87
Copy link
Member

Turbo87 commented Feb 6, 2019

oh dear... thanks for letting us know 😢

any idea what could be causing it?

@rwjblue
Copy link
Member

rwjblue commented Feb 8, 2019

I just verified that the problem exists on the beta branch before any of my changes are applied

Hmm, are you sure? https://travis-ci.org/ember-cli/ember-cli/builds/490530380 passed on beta branch just a few hours ago...

@mistahenry
Copy link
Author

mistahenry commented Feb 9, 2019

@rwjblue I think something lingered in my /tmp after failing. I pulled down a fresh beta branch and the tests passed.

I looked into what is happening some this morning, and it seems the work done here #24 is most likely causing the test suite to stall. If I downgrade the ember-optional-features to 0.6.4 the tests pass

When I leave ember-optional-features: ^0.7.0 as a dependency, the test suite stalls unless if I have no optional-features.json, it's empty {}, or I explicitly delete the _JQUERY_INTEGRATION entry in EmberENV before it's set on the index.html <meta> tag. The app's optional-features.json that is used during testing is explicitly setting jquery-enabled: true

If I remove the jquery line altogether and switch to an explicit

{
  'application-template-wrapper': true
}

this smoke test hangs again until I explicitly delete the _APPLICATION_TEMPLATE_WRAPPER similarly from EmberENV

Any ideas?

@Turbo87
Copy link
Member

Turbo87 commented Feb 9, 2019

@mistahenry I would suggest reverting the optional-features update for now to unblock all the other updates. We can then figure out what is causing the test failures in a second step.

@mistahenry
Copy link
Author

I fixed the optional features issue. I really haven't a clue why the wasm test is failing in CI. Locally it succeeds every time for me when I run nvm install 6 && yarn test:all.

@rwjblue
Copy link
Member

rwjblue commented Feb 11, 2019

Restarted the Node 6 job.

@mistahenry
Copy link
Author

The node 6 job is consistently failing. I'm going to try to figure out how to get proper subprocess logging. What I've been seeing rather consistently across multiple failing "smoke tests" is that when the expectation fails, the test simply hangs and it's hard to tell why

@ppcano
Copy link
Contributor

ppcano commented Feb 14, 2019

@mistahenry

  1. Please, could you kindly update ember-welcome-page=^4.0.0 in this PR as well?
    Support Angle Bracket syntax and MU layout ember-welcome-page#124

  2. It could be a good addition if you update the module-unification-addon and module-unification-app blueprints too? I will create an additional PR otherwise.

Thank you!

@mistahenry
Copy link
Author

@ppcano happy to do both.

@ppcano
Copy link
Contributor

ppcano commented Feb 14, 2019

The same error in Node 6 has failed at https://travis-ci.org/ember-cli/ember-cli/jobs/493437821; #8434 only changes a code comment.

I think the CI job failure may not be related to this PR changes.

@mistahenry
Copy link
Author

@ppcano yeah I've now seen the same Node 6 issue in a couple of unrelated places like the 3.7.1 build

@simonihmig
Copy link
Contributor

I think it's getting a bit urgent to land this for the stable 3.9 release, at the minimum updating @ember/jquery, as the jQuery deprecations will land in that release in Ember, and a newly created app should not show deprecation warnings obviously.

Apart from the merge conflicts, this is still blocked on the failing node 6 test?

@Turbo87
Copy link
Member

Turbo87 commented Mar 10, 2019

@simonihmig see #8466

once this PR is rebased CI should hopefully be green. feel free to open a PR against beta that just updates the jquery dep if you want to speed up the process 😉

@mistahenry
Copy link
Author

@Turbo87 @simonihmig rebased and all green in the CI

@Turbo87 Turbo87 changed the base branch from beta to master March 16, 2019 11:38
@Turbo87 Turbo87 changed the title update new app / addon deps to latest blueprints: Update dependencies Mar 16, 2019
@Turbo87
Copy link
Member

Turbo87 commented Mar 16, 2019

@mistahenry thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants