New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blueprints: Update dependencies #8396
Conversation
looks like some update in this PR is failing CI. might be related to #8080 also not passing. |
@Turbo87 I just verified that the problem exists on the |
oh dear... thanks for letting us know 😢 any idea what could be causing it? |
Hmm, are you sure? https://travis-ci.org/ember-cli/ember-cli/builds/490530380 passed on beta branch just a few hours ago... |
@rwjblue I think something lingered in my /tmp after failing. I pulled down a fresh beta branch and the tests passed. I looked into what is happening some this morning, and it seems the work done here #24 is most likely causing the test suite to stall. If I downgrade the When I leave If I remove the jquery line altogether and switch to an explicit {
'application-template-wrapper': true
} this smoke test hangs again until I explicitly delete the Any ideas? |
@mistahenry I would suggest reverting the |
6ddc255
to
acdd1ff
Compare
I fixed the optional features issue. I really haven't a clue why the |
Restarted the Node 6 job. |
The node 6 job is consistently failing. I'm going to try to figure out how to get proper subprocess logging. What I've been seeing rather consistently across multiple failing "smoke tests" is that when the expectation fails, the test simply hangs and it's hard to tell why |
9295040
to
acdd1ff
Compare
Thank you! |
@ppcano happy to do both. |
The same error in Node 6 has failed at https://travis-ci.org/ember-cli/ember-cli/jobs/493437821; #8434 only changes a code comment. I think the CI job failure may not be related to this PR changes. |
@ppcano yeah I've now seen the same Node 6 issue in a couple of unrelated places like the 3.7.1 build |
I think it's getting a bit urgent to land this for the stable 3.9 release, at the minimum updating Apart from the merge conflicts, this is still blocked on the failing node 6 test? |
@simonihmig see #8466 once this PR is rebased CI should hopefully be green. feel free to open a PR against |
@Turbo87 @simonihmig rebased and all green in the CI |
@mistahenry thanks!! |
Fixes 8395