Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU blueprints: enable EMBER_MODULE_UNIFICATION feature flag #8433

Merged
merged 1 commit into from Feb 14, 2019

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Feb 14, 2019

Thanks to @patricklx for finding and providing the fix of this issue at #8424 (comment)

The MU blueprints were not enabling the EMBER_MODULE_UNIFICATION Ember Feature Flag. This PR enables it (I will also add it to the octane blueprints).

Relates #8431 and #8424


I have reviewed the Ember code and it looks that there is an issue regarding how Ember Feature Flags works: the Feature Flags doc and guide looks to indicate that the feature key should be in dash and lowercase format, but I could not find in the Ember code that a key transformation from lowercase to uppercase format.

Should it be enabled in lowercase and fix the issue or should the documentation be updated?

@ppcano ppcano changed the title WIP - MU blueprints: enable EMBER_MODULE_UNIFICATION feature flag MU blueprints: enable EMBER_MODULE_UNIFICATION feature flag Feb 14, 2019
@rwjblue
Copy link
Member

rwjblue commented Feb 14, 2019

Should it be enabled in lowercase and fix the issue or should the documentation be updated?

The documentation should be updated. When it was originally authored we did use lower case dasherized keys, now we use SCREAMING_SNAKE_CASE. The main reason for the change was that with SCREAMING_SNAKE_CASE we can use them directly as identifiers in javascript/typescript code whereas foo-bar-baz cannot be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants