Remove unused testing helper files. #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
approved these changes
Jan 11, 2018
kellyselden
approved these changes
Jan 11, 2018
|
We noticed on the call that some addons are putting things in these files. We will need to be aware of this. |
rwjblue
force-pushed
the
remove-extraneous-test-files
branch
5 times, most recently
from
fdcc73b
to
9e6e1b1
Compare
As of ember-source@3.0.0 (and ember-data@3.0.0) the testing blueprints are automatically emitting emberjs/rfcs#232 or emberjs/rfcs#268 compatible output. With those, these helpers are no longer used for new apps. Existing apps should only delete these files once they have migrated to the new testing system...
This option was added at a time where the default ember-cli blueprint did not include any eslint config (it was housed in ember-cli-eslint itself and only added during `ember new` by running the `ember-cli-eslint` blueprint). At that time a basic ESLint config was needed to prevent tests from completely blowing up, so this option was added... Fast-forward to the present: the default eslint configuration is now managed by ember-cli itself, and this override option is not providing value (in fact it is adding pain because it does not confirm the default blueprint passes linting). This commit removes the now unneeded feature...
rwjblue
force-pushed
the
remove-extraneous-test-files
branch
from
9e6e1b1
to
b8739d2
Compare
|
@rwjblue i'm using the new QUnit API, but for an instance initializer test, i'm still using example: https://github.com/mirai-audio/mir/blob/16/library/tests/unit/instance-initializers/i18n-test.js#L36 |
This was referenced Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ember-source@3.0.0 (and ember-data@3.0.0) the testing blueprints
are automatically emitting emberjs/rfcs#232 or emberjs/rfcs#268
compatible output. With those, these helpers are no longer used for new
apps.
Existing apps should only delete these files once they have migrated to
the new testing system...