Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
createESLintConfig
option from tests/helpers/acceptance.
This option was added at a time where the default ember-cli blueprint did not include any eslint config (it was housed in ember-cli-eslint itself and only added during `ember new` by running the `ember-cli-eslint` blueprint). At that time a basic ESLint config was needed to prevent tests from completely blowing up, so this option was added... Fast-forward to the present: the default eslint configuration is now managed by ember-cli itself, and this override option is not providing value (in fact it is adding pain because it does not confirm the default blueprint passes linting). This commit removes the now unneeded feature...
- Loading branch information
Showing
12 changed files
with
17 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
tests/fixtures/brocfile-tests/custom-environment-config/tests/unit/config-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import { test } from 'qunit'; | ||
import config from '../../config/environment'; | ||
|
||
QUnit.test('the correct config is used', function(assert) { | ||
test('the correct config is used', function(assert) { | ||
assert.equal(config.fileUsed, 'config/something-else.js'); | ||
}); |
1 change: 0 additions & 1 deletion
1
tests/fixtures/brocfile-tests/pods-templates/tests/integration/pods-template-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
tests/fixtures/brocfile-tests/pods-with-prefix-templates/app/app.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...ixtures/brocfile-tests/pods-with-prefix-templates/tests/integration/pods-template-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
tests/fixtures/smoke-tests/failing-test/tests/unit/some-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
QUnit.test('failing test', function(assert) { | ||
import { test } from 'qunit'; | ||
|
||
test('failing test', function(assert) { | ||
assert.ok(false, 'test should fail to confirm ember test exit code'); | ||
}); |
4 changes: 3 additions & 1 deletion
4
tests/fixtures/smoke-tests/passing-test/tests/unit/some-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
QUnit.test('passing test', function(assert) { | ||
import { test } from 'qunit'; | ||
|
||
test('passing test', function(assert) { | ||
assert.ok(true, 'test should pass'); | ||
}); |
4 changes: 3 additions & 1 deletion
4
tests/fixtures/smoke-tests/test-with-syntax-error/tests/unit/some-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
QUnit.test('syntax error', function(assert) { | ||
import { test } from 'qunit'; | ||
|
||
test('syntax error', function(assert) { | ||
# syntax error | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters