Make addAddonsToProject support creating a new project with custom target directory #10048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
force-pushed
the
addAddonsToProject-custom-target
branch
from
866d3b8
to
2131cfa
Compare
2 tasks
ef4
force-pushed
the
addAddonsToProject-custom-target
branch
from
2131cfa
to
ea7b66a
Compare
|
Thanks! |
simonihmig
added a commit
to embroider-build/addon-blueprint
that referenced
this pull request
Jan 6, 2023
CI currently fails the typescript tests, due to a known issue that the latest stable version (4.9.x) of ember-cli support `--typescript`, but a fix when generating the app in a custom directory (ember-cli/ember-cli#10048) is only released for the 4.10.0-beta version. Se we use the latter in CI.
simonihmig
added a commit
to embroider-build/addon-blueprint
that referenced
this pull request
Jan 6, 2023
CI currently fails the typescript tests, due to a known issue that the latest stable version (4.9.x) of ember-cli support `--typescript`, but a fix when generating the app in a custom directory (ember-cli/ember-cli#10048) is only released for the 4.10.0-beta version. Se we use the latter in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #9972 we (@ef4 specifically) made
addAddonsToProjectsupport to be called as part of generating a new project. However when we are calling the app blueprint programmatically and passing a customoptions.target, it would try to install the requested dependencies in the wrong folder (not the one specified inoptions.target).This popped up when trying to pass the
--typescriptflag in the v2 addon blueprint when creating the separate (TS enabled) test-app. Here we are operating in a monorepo, where the test-app is in a subfolder. When we delegate the test-app generation to the app blueprint here, its call toaddAddonsToProjectforember-cli-typescripthere would fail. The test-app would correctly be scaffolded in the right subfolder, however it would try to installember-cli-typescriptin the monorepo's root folder. Which is wrong, and which yarn would refuse to do.