Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot generate addon with typescript #82

Closed
mfeckie opened this issue Dec 29, 2022 · 2 comments
Closed

Cannot generate addon with typescript #82

mfeckie opened this issue Dec 29, 2022 · 2 comments

Comments

@mfeckie
Copy link

mfeckie commented Dec 29, 2022

ember -v
ember-cli: 4.9.2
node: 18.12.1
os: darwin arm64

Executing ember addon demo -b @embroider/addon-blueprint --typescript results in

  create tests/integration/.gitkeep
  create tests/test-helper.ts
  create tests/unit/.gitkeep
  install addon ember-cli-typescript

🚧  Installing packages... This might take a couple of minutes.
Error creating new application. Removing generated directory `./demo`
Command failed with exit code 1: yarn add --dev ember-cli-typescript --non-interactive
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
yarn add v1.22.19

Running ember addon demo -b @embroider/addon-blueprint --typescript -W results in the same issue

Running ember addon v2-demo -b @embroider/addon-blueprint --typescript --ignore-workspace-root-check also has the same error

@simonihmig
Copy link
Collaborator

This just came up on Discord as well... it turned out that ember-cli ships with --typescript support starting at 4.9.0 (current stable), but a necessary fix (ember-cli/ember-cli#10048) to make it work within this blueprint was not merged in time, it is only available with 4.10.0-beta.0 (see https://github.com/ember-cli/ember-cli/releases/tag/v4.10.0-beta.0). Using that version should work!

@mfeckie
Copy link
Author

mfeckie commented Jan 5, 2023

Thanks

@mfeckie mfeckie closed this as completed Jan 5, 2023
simonihmig added a commit that referenced this issue Jan 12, 2023
Skip `--typescript` tests temporarily due to #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants