Update ember-cli-babel to v7.x and use native Error instead of EmberError
#433
Conversation
There was a problem hiding this comment.
due to the modified Ember CLI version requirement and the base class change this should be considered a breaking change and requires a major version bump
@alexlafroscia please confirm that this is okay with you. I would merge, but I don't have the necessary npm permissions so I wouldn't be able to release anyway 😉
| import EmberError from '@ember/error'; | ||
|
|
||
| export class AjaxError extends EmberError { | ||
| export class AjaxError extends Error { |
There was a problem hiding this comment.
to be a bit more verbose here: Ember 3.8 changed EmberError to no longer be an Error subclass, but instead reexport Error. Babel 6 can't deal with extending native classes, but Babel 7 can. Babel 7 does not detect that it needs to do that though because of the reexport.
Since the bump to ember-cli-babel@7 and the corresponding change in the minimum Ember CLI requirements require a major version bump anyway it seems fine to change the base class here to a regular Error too.
There was a problem hiding this comment.
you just solved why we couldn't figure out subclassing with that change properly in ember-data (not detecting the native class due to re-export)
|
merging now as it will fix the CI issues and unblock the other PRs @alexlafroscia if you don't have time for it right now, I'm happy to handle the release, just need the npm permissions 😉 |
Turbo87
changed the title
ember-cli-babel to v7.x and use native Error instead of EmberError
Fixes #431.