Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

ember-ajax does not work with Ember 3.8 when transpiling to ES5 #431

Closed
boris-petrov opened this issue Feb 28, 2019 · 1 comment
Closed

Comments

@boris-petrov
Copy link
Contributor

Original issue in Ember.js.

Babel cannot transpile to ES5 extending from some built-in types which means that extending EmberError won't work any more in ES5 since Ember 3.8 because it is the same as Error.

@Turbo87
Copy link
Member

Turbo87 commented Feb 28, 2019

as mentioned on Discord, the way I would propose to fix this is:

  1. update ember-cli-babel to v7 and check if that fixes the test suite
  2. update the Node.js compatibility claims in package.json and PR it (see Fix Node.js compatibility claim in package.json #432)
  3. open a PR for 1) which also updates the "Compatibility" section, adding CLI 2.13+ requirement (see Update ember-cli-babel to v7.x and use native Error instead of EmberError #433)
  4. get it released as v5.0.0
  5. update the app blueprint in Ember CLI
  6. get that released as v3.8.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants