Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(maker-pkg): add targetArch to pkg name #3057

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix(maker-pkg): add targetArch to pkg name #3057

merged 1 commit into from Nov 9, 2022

Conversation

erickzhao
Copy link
Member

Supersedes #2726

there's some weirdness rebasing when pulling from the master branch of a fork I don't want to deal with.

@erickzhao erickzhao changed the title chore(maker-pkg): Added targetArch to make output name fix(maker-pkg): add targetArch to pkg name Nov 8, 2022
@erickzhao erickzhao mentioned this pull request Nov 8, 2022
Closed
5 tasks
@erickzhao erickzhao marked this pull request as ready for review November 9, 2022 06:39
@erickzhao erickzhao requested a review from a team November 9, 2022 06:39
BlackHole1
BlackHole1 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzhao erickzhao merged commit 344a0af into main Nov 9, 2022
@erickzhao erickzhao deleted the pkg-add-target-arch branch November 9, 2022 19:48
@BlackHole1 BlackHole1 mentioned this pull request Nov 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erickzhao @MarshallOfSound @BlackHole1 @nsainaney