Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maker-pkg): allow to override .pkg name #1785

Merged
merged 4 commits into from Nov 14, 2022
Merged

Conversation

mahnunchik
Copy link
Contributor

ISSUES CLOSED: #1784

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Allow to override .pkg filename.

@mahnunchik
Copy link
Contributor Author

@malept could you please have a look at this PR

@mahnunchik
Copy link
Contributor Author

@malept What should I do to have this PR merged?

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #1785 (384dda9) into master (4824af6) will increase coverage by 12.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1785       +/-   ##
===========================================
+ Coverage   60.28%   72.71%   +12.42%     
===========================================
  Files          71       74        +3     
  Lines        2153     2221       +68     
  Branches      411      421       +10     
===========================================
+ Hits         1298     1615      +317     
+ Misses        676      446      -230     
+ Partials      179      160       -19     
Impacted Files Coverage Δ
packages/maker/pkg/src/MakerPKG.ts 92.85% <100.00%> (ø)
packages/utils/async-ora/src/index.ts 100.00% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (ø)
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (ø)
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (ø)
packages/utils/test-utils/src/index.ts 85.71% <0.00%> (+3.10%) ⬆️
packages/utils/async-ora/src/ora-handler.ts 90.00% <0.00%> (+3.33%) ⬆️
packages/maker/deb/src/MakerDeb.ts 100.00% <0.00%> (+5.26%) ⬆️
packages/maker/rpm/src/MakerRpm.ts 100.00% <0.00%> (+5.26%) ⬆️
packages/maker/dmg/src/MakerDMG.ts 100.00% <0.00%> (+5.55%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4824af6...384dda9. Read the comment docs.

@mahnunchik
Copy link
Contributor Author

@malept PR has been updated on latest master.

@mahnunchik
Copy link
Contributor Author

@malept ping

@Karmel85
Copy link

Karmel85 commented Mar 2, 2022

@malept ping

Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I'm sorry to review the code only now. 🙇‍♂️
Looks great, just needs some minor improvements.

packages/maker/pkg/src/MakerPKG.ts Outdated Show resolved Hide resolved
packages/maker/pkg/src/Config.ts Outdated Show resolved Hide resolved
@mahnunchik
Copy link
Contributor Author

Done! I'm looking forward to have it merged.

@BlackHole1
Copy link
Member

Hey @mahnunchik CI failed.

image

Can you execute Prettier locally?

@mahnunchik
Copy link
Contributor Author

All done!

@BlackHole1
Copy link
Member

@mahnunchik This PR has a conflict because #3057 was merged, can you fix it? 🙇‍♂️

@mahnunchik
Copy link
Contributor Author

@BlackHole1 what is wrong with CI tests? I've rebased PR on current main.

@BlackHole1
Copy link
Member

Test case need modify and should be a simple.

@mahnunchik
Copy link
Contributor Author

@BlackHole1 mistypo while rebase has been fixed

Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahnunchik
Copy link
Contributor Author

I'm looking forward to have this PR merged 😉

@erickzhao erickzhao merged commit e9b4576 into electron:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to override .pkg name
4 participants