Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to GtkStatusIcon when app indicator is not supported #37034

Merged
merged 2 commits into from Jan 26, 2023

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 26, 2023

Backport of #36815

See that PR for details.

Notes: Fix tray icon not showing on desktop environments that have no support for app indicator.

trop bot and others added 2 commits January 26, 2023 19:18
Co-authored-by: Milan Burda <miburda@microsoft.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <miburda@microsoft.com>
…36815)

* chore: get ready for multi backend tray

* fix: fallback to GtkStatusIcon when app indicator is not supported

* chore: use smart pointers
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 26, 2023
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 26, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 26, 2023
@codebytere codebytere merged commit 4f5432e into 22-x-y Jan 26, 2023
@codebytere codebytere deleted the tray-gtk-backend-22 branch January 26, 2023 12:39
@release-clerk
Copy link

release-clerk bot commented Jan 26, 2023

Release Notes Persisted

Fix tray icon not showing on desktop environments that have no support for app indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants