New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: determine electron version from tags not files #36106
Conversation
1848135
to
d7cd709
Compare
45b6849
to
16b8516
Compare
No Release Notes |
I was unable to backport this PR to "19-x-y" cleanly; |
I was unable to backport this PR to "20-x-y" cleanly; |
I was unable to backport this PR to "21-x-y" cleanly; |
I was unable to backport this PR to "22-x-y" cleanly; |
@VerteDinde has manually backported this PR to "21-x-y", please check out #36135 |
@VerteDinde has manually backported this PR to "20-x-y", please check out #36136 |
@VerteDinde has manually backported this PR to "19-x-y", please check out #36137 |
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: Samuel Attard <sattard@salesforce.com>
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: Samuel Attard <sattard@salesforce.com>
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@salesforce.com>
* build: determine electron version from tags not files (#36106) * build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> * chore: fixup patches * chore: update patches * build: ensure get-version runs in the electron git checkout (#36128) * build: strip v in the getElectronVersion helper * build: use npm@7 for npm view command Co-authored-by: Samuel Attard <sam@electronjs.org> Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@salesforce.com>
* build: determine electron version from tags not files * build: make electron_version dependent on packed-refs and git HEAD * build: do not delete electron/.git * build: do not revert a commit we didn't make * build: gen version file instead of just writing it * build: update cache and ninja targets * build: copy resource.h to generated electron.rc * build: electron_win32_resources should be public deps * build: also copy the icon
This does a few cool things
electron.rc
is now generated instead of being updated via the bump scriptSUPPORT.md
is no longer updated automatically (we should replace this with some other automation)All this means that we should be able to turn on signed commit enforcement because sudowoodo will no longer need to push commits.
Notes: no-notes