Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Load Examples From Docs #1217

Closed
dsanders11 opened this issue Dec 7, 2022 · 0 comments · Fixed by #1218
Closed

Can't Load Examples From Docs #1217

dsanders11 opened this issue Dec 7, 2022 · 0 comments · Fixed by #1218
Labels
🪲 bug Something isn't working

Comments

@dsanders11
Copy link
Member

Loading an example from the docs for Electron versions greater than v21.1.0 no longer works after electron/electron#36106 since package.json doesn't have the version bumped. When Fiddle tries to load an example it'll try to set the Electron version to v0.0.0-development as a result.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't check package.json version for Electron examples dsanders11/fiddle
1 participant
@dsanders11