fix: on-screen-keyboard hides on input blurred in webview #35921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo-hrechykhin
force-pushed
the
fix/34300-osk-does-not-hide-on-input-in-webview-blurred
branch
2 times, most recently
from
eddd00b
to
d0a3be8
Compare
zcbenz
approved these changes
Oct 11, 2022
zcbenz
added
semver/patch
zcbenz
force-pushed
the
fix/34300-osk-does-not-hide-on-input-in-webview-blurred
branch
from
d0a3be8
to
56be201
Compare
|
Kindly asking contributors to review/merge this PR. |
kyrylo-hrechykhin
force-pushed
the
fix/34300-osk-does-not-hide-on-input-in-webview-blurred
branch
from
56be201
to
77fe69e
Compare
jkleinsc
approved these changes
Oct 11, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "20-x-y", please check out #35981 |
|
I have automatically backported this PR to "21-x-y", please check out #35982 |
|
I have automatically backported this PR to "22-x-y", please check out #35983 |
trop
bot
removed
the
target/21-x-y
trop
bot
added
in-flight/22-x-y
merged/22-x-y
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…5921) Co-authored-by: Kyrylo Hrechykhin <khrechykhin@microsoft.com>
zcbenz
added a commit
that referenced
this pull request
Jan 26, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
zcbenz
added a commit
that referenced
this pull request
Jan 26, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
5 tasks
zcbenz
added a commit
that referenced
this pull request
Jan 26, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
zcbenz
added a commit
that referenced
this pull request
Jan 29, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
trop bot
added a commit
that referenced
this pull request
Jan 29, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron. Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2024
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding patch that fixes on-screen-keyboard (OSK) not hiding on input rendered in webview is blurred. The issue is chromium based (mentioned in the patch) , however it is not clear how to fix it. Changes introduced by this patch fix issue in at least one user case -- where input is blurred due to something else inside the same webview is focused. Changes do not cover the case where input in the webview is blurred due to something else is focused outside of webview. Technically in this case input inside the webview won't be blurred at all due to implementation details of webview.
Checklist
npm testpassesRelease Notes
Notes: Fixed on-screen-keyboard not hiding on input rendered in webview is blurred.