Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OSK does not hide on input rendered inside webview is blurred #34300

Closed
3 tasks done
kyrylo-hrechykhin opened this issue May 20, 2022 · 3 comments
Closed
3 tasks done
Labels
bug 🪲 has-repro-repo Issue can be reproduced by cloning a git repo platform/windows

Comments

@kyrylo-hrechykhin
Copy link
Contributor

Preflight Checklist

Electron Version

16.2.5

What operating system are you using?

Windows

Operating System Version

Windows 11, Version21H2, OS Build 22000.613

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

OSK hides if input rendered in the webview loses its focus.

Actual Behavior

OSK does not hide if input rendered only in the webview loses its focus.

Testcase Gist URL

https://github.com/kyrylo-hrechykhin/electron-osk-webview-test

Additional Information

The issue is related to touch devices only and webview tag.

The issue is that input rendered in the webview does not hide OSK when something else is getting the focus. The reason why it is considered an issue -> iframe and simple textarea does not work like that.

I also created a demo app where this issue can be easily reproduced. Just run the app, touch input in the webview and then touch something else except input elements.

@VerteDinde VerteDinde added platform/windows has-repro-repo Issue can be reproduced by cloning a git repo labels May 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@kyrylo-hrechykhin
Copy link
Contributor Author

kyrylo-hrechykhin commented Oct 5, 2022

Bump and update.

Issue is still present and not fixed.
Resolving of the issue is moved to chromium repo -- https://bugs.chromium.org/p/chromium/issues/detail?id=1369605. Even though it is still not clear how to fix it properly, there was a suggestion on how it can be fixed. I tried those changes and they work in one case -- where second tap is happening inside the same webview. It still does not work if second tap is somewhere else. Anyway, I believe that patch with those changes can be created in order to cover at least most popular user case with the fix. If proper fix is created, the patch can be easily removed.

I invite everyone who is affected by this bug to discuss and propose fixes in chromium work item.

@kyrylo-hrechykhin
Copy link
Contributor Author

This bug is fixed for one use-case in the following PR: #35921
Use-case is when input rendered in webview loses its focus due to something else inside the same webview gets focused.

Successor issue for another one use case is created: #36000
This issue can be considered closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 has-repro-repo Issue can be reproduced by cloning a git repo platform/windows
Projects
None yet
Development

No branches or pull requests

2 participants