Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use webContents.mainFrame.on() in MessagePort tutorial #35824

Merged
merged 2 commits into from
Oct 12, 2022
Merged

docs: use webContents.mainFrame.on() in MessagePort tutorial #35824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0604f6
docs: use webContents.mainFrame.on() in MessagePort tutorial
miniak Sep 26, 2022
3d07cde
Update docs/tutorial/message-ports.md
miniak Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 9 additions & 13 deletions docs/tutorial/message-ports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,19 +180,15 @@ app.whenReady().then(async () => {

// We can't use ipcMain.handle() here, because the reply needs to transfer a
// MessagePort.
ipcMain.on('request-worker-channel', (event) => {
// For security reasons, let's make sure only the frames we expect can
// access the worker.
if (event.senderFrame === mainWindow.webContents.mainFrame) {
// Create a new channel ...
const { port1, port2 } = new MessageChannelMain()
// ... send one end to the worker ...
worker.webContents.postMessage('new-client', null, [port1])
// ... and the other end to the main window.
event.senderFrame.postMessage('provide-worker-channel', null, [port2])
// Now the main window and the worker can communicate with each other
// without going through the main process!
}
mainWindow.webContents.mainFrame.on('request-worker-channel', (event) => {
miniak marked this conversation as resolved.
Show resolved Hide resolved
// Create a new channel ...
const { port1, port2 } = new MessageChannelMain()
// ... send one end to the worker ...
worker.webContents.postMessage('new-client', null, [port1])
// ... and the other end to the main window.
event.senderFrame.postMessage('provide-worker-channel', null, [port2])
// Now the main window and the worker can communicate with each other
// without going through the main process!
})
})
```
Expand Down