Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use webContents.mainFrame.on() in MessagePort tutorial #35824

Merged
merged 2 commits into from Oct 12, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 26, 2022

Description of Change

Follow-up to #34959

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Sep 26, 2022
@miniak miniak changed the title docs: use mainWindow.mainFrame.on() in MessagePort tutorial docs: use webContents.mainFrame.on() in MessagePort tutorial Sep 26, 2022
@miniak miniak self-assigned this Sep 26, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

MarshallOfSound
MarshallOfSound previously approved these changes Oct 3, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: test

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@MarshallOfSound MarshallOfSound dismissed stale reviews from electron-docs-reviewer and themself October 3, 2022 09:05

nope

MarshallOfSound
MarshallOfSound previously approved these changes Oct 3, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: test

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@electron-docs-reviewer electron-docs-reviewer bot dismissed their stale review October 3, 2022 09:08

Dismissing docs review on behalf of the Electron Docs Team

Co-authored-by: Samuel Maddock <smaddock@salesforce.com>
@jkleinsc jkleinsc merged commit 1328d8d into main Oct 12, 2022
@jkleinsc jkleinsc deleted the miniak/message-ports-ipc branch October 12, 2022 14:27
@release-clerk
Copy link

release-clerk bot commented Oct 12, 2022

No Release Notes

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
…n#35824)

* docs: use webContents.mainFrame.on() in MessagePort tutorial

* Update docs/tutorial/message-ports.md

Co-authored-by: Samuel Maddock <smaddock@salesforce.com>

Co-authored-by: Samuel Maddock <smaddock@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants