Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app.getSystemLocale() method #35697

Merged
merged 13 commits into from Sep 23, 2022
Merged

feat: add app.getSystemLocale() method #35697

merged 13 commits into from Sep 23, 2022

Commits on Sep 16, 2022

  1. feat: add app.getSystemLocale() method

    @rzhao271
    rzhao271 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    5a63149 View commit details
    Browse the repository at this point in the history

  2. Update shell/browser/electron_browser_main_parts.cc 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @rzhao271 @ckerr
    rzhao271 and ckerr committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d448091 View commit details
    Browse the repository at this point in the history

  3. Change methods to be const

    @rzhao271
    rzhao271 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    4cda823 View commit details
    Browse the repository at this point in the history

  4. Apply PR feedback

    @rzhao271
    rzhao271 committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    5441c9e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Fix mac compile

    @rzhao271
    rzhao271 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    f43b405 View commit details
    Browse the repository at this point in the history

  2. Add missing scope

    @rzhao271
    rzhao271 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    6a93b36 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Apply style changes

    @rzhao271
    rzhao271 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    532d38e View commit details
    Browse the repository at this point in the history

  2. Change note

    @rzhao271
    rzhao271 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    077531f View commit details
    Browse the repository at this point in the history

  3. Add braces to get the comment indentation right

    @rzhao271
    rzhao271 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    e707b7f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Change to static

    @rzhao271
    rzhao271 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    3f13ff3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Apply PR feedback

    @rzhao271
    rzhao271 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7d2706d View commit details
    Browse the repository at this point in the history

  2. Fix the documentation

    @rzhao271
    rzhao271 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    746beed View commit details
    Browse the repository at this point in the history

  3. Remove extraneous file

    @rzhao271
    rzhao271 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    74a9998 View commit details
    Browse the repository at this point in the history