feat: add app.getSystemLocale() method #35697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Sep 15, 2022
rzhao271
force-pushed
the
rzhao271/set-system-locale
branch
from
e48afc1
to
f28d1c2
Compare
ckerr
previously approved these changes
Sep 15, 2022
ckerr
added
enhancement ✨
api-review/requested 🗳
target/21-x-y
ckerr
force-pushed
the
rzhao271/set-system-locale
branch
from
f8677e4
to
7de0965
Compare
deepak1556
requested changes
Sep 16, 2022
Co-authored-by: Charles Kerr <charles@charleskerr.com>
rzhao271
force-pushed
the
rzhao271/set-system-locale
branch
from
6811bba
to
5441c9e
Compare
deepak1556
reviewed
Sep 19, 2022
ckerr
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
impl looks fine.
Deferring to @deepak1556's better wisdom on the macOS string underscores vs dashes, since I didn't know about that issue. Looks like the new test code ensures the values are hyphenated 👍
rzhao271
force-pushed
the
rzhao271/set-system-locale
branch
from
1d49ce6
to
3f13ff3
Compare
|
API LGTM |
deepak1556
reviewed
Sep 21, 2022
deepak1556
approved these changes
Sep 22, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "21-x-y", please check out #35794 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
trop
bot
added
merged/21-x-y
7 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: add app.getSystemLocale() method * Update shell/browser/electron_browser_main_parts.cc Co-authored-by: Charles Kerr <charles@charleskerr.com> * Change methods to be const * Apply PR feedback * Fix mac compile * Add missing scope * Apply style changes * Change note * Add braces to get the comment indentation right * Change to static * Apply PR feedback * Fix the documentation * Remove extraneous file Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a method to fetch the OS locale from Chromium. That way, even when the application is in a certain locale, the program can still know the system locale and make recommendations based off of that.
Downstream: microsoft/vscode#159813 and PR microsoft/vscode#159958.
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Added
app.getSystemLocale()method.