Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider dock space when showing menu #35194

Merged
merged 1 commit into from Aug 3, 2022
Merged

fix: consider dock space when showing menu #35194

merged 1 commit into from Aug 3, 2022

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 3, 2022

Description of Change

Use visibleFrame instead of frame when computing edge of screen, the former excludes the dock and menubar from the frame.

Close #14261.

Checklist

Release Notes

Notes: Fix context menu not showing all items on macOS when dock is not hidden.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/18-x-y labels Aug 3, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2022
@bpasero bpasero mentioned this pull request Aug 3, 2022
Closed
@deepak1556 deepak1556 merged commit afa4f50 into main Aug 3, 2022
@deepak1556 deepak1556 deleted the menu-pos-dock branch August 3, 2022 08:52
@release-clerk
Copy link

release-clerk bot commented Aug 3, 2022

Release Notes Persisted

Fix context menu not showing all items on macOS when dock is not hidden.

This was referenced Aug 3, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 3, 2022

I have automatically backported this PR to "18-x-y", please check out #35198

@trop
Copy link
Contributor

trop bot commented Aug 3, 2022

I have automatically backported this PR to "19-x-y", please check out #35199

@trop
Copy link
Contributor

trop bot commented Aug 3, 2022

I have automatically backported this PR to "20-x-y", please check out #35200

@silverwind silverwind mentioned this pull request Aug 3, 2022
Closed
@trop trop bot added the merged/20-x-y label Aug 4, 2022
@trop trop bot removed the in-flight/20-x-y label Aug 4, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 4, 2022
@commit-lint commit-lint bot mentioned this pull request Oct 12, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@zcbenz @schetle
fix: consider dock space when showing menu (electron#35194)
a4b2142
@bpasero
Copy link
Contributor

bpasero commented Jan 19, 2023

Is there any chance this broke again with Electron 22? Seeing it again in VS Code:

image

//cc @deepak1556

@bpasero
Copy link
Contributor

bpasero commented Jan 19, 2023

Seems flaky, now I cannot reproduce anymore, but will keep an eye open.

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@zcbenz @khalwa
fix: consider dock space when showing menu (electron#35194)
9824001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having config menu popping up above bottom of windows instead of having to scroll.
4 participants
@zcbenz @bpasero @deepak1556 @MarshallOfSound