Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BrowserView background color in webContents #33545

Closed
wants to merge 2 commits into from
Closed

fix: BrowserView background color in webContents #33545

wants to merge 2 commits into from

Conversation

codebytere
Copy link
Member

Backport of #33435.

See that PR for details.

Notes: Fixed an issue with background colors being improperly applied to BrowserViews on Windows.

@codebytere
fix: BrowserView background color in webContents
cf6abb8 
* chore: fix BrowserView background color in webContents

* disable screen capture test on linux

* spec: fix platform failure condition
@codebytere codebytere requested a review from a team March 31, 2022 08:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2022
@trop trop bot mentioned this pull request Mar 31, 2022
Merged
4 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2022
@codebytere codebytere mentioned this pull request Mar 31, 2022
Merged
@electron electron deleted a comment from trop bot Mar 31, 2022
zcbenz
zcbenz reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typescript error:

electron/spec-main/api-browser-view-spec.ts(7,64): error TS2307: Cannot find module './screen-helpers' or its corresponding type declarations.

@codebytere
Copy link
Member Author

@zcbenz yes, this is pending #33562 and needs a rebase once that's merged.

miniak
miniak requested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems to be regressing #31722

@codebytere codebytere closed this Jun 21, 2022
@codebytere codebytere deleted the bg-color-bv-17 branch June 21, 2022 12:31
@miniak miniak restored the bg-color-bv-17 branch June 29, 2022 17:09
@miniak miniak reopened this Jun 29, 2022
@miniak
Copy link
Contributor

miniak commented Jun 29, 2022

@codebytere considering this fix was merged into 16-x-y, I would merge it to 17-x-y as well for consistency.

@miniak miniak self-requested a review June 29, 2022 17:10
@miniak miniak closed this Aug 4, 2022
@miniak miniak deleted the bg-color-bv-17 branch August 4, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz left review comments

@miniak miniak miniak approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @miniak @zcbenz @VerteDinde