Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BrowserView background color in webContents #33546

Merged
merged 1 commit into from May 24, 2022

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 31, 2022

Backport of #33435.

See that PR for details.

Notes: Fixed an issue with background colors being improperly applied to BrowserViews on Windows.

@codebytere codebytere requested a review from a team March 31, 2022 08:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2022
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2022
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typescript error:

electron/spec-main/api-browser-view-spec.ts(7,64): error TS2307: Cannot find module './screen-helpers' or its corresponding type declarations.

* chore: fix BrowserView background color in webContents

* disable screen capture test on linux

* spec: fix platform failure condition
@VerteDinde VerteDinde merged commit 83f6303 into 16-x-y May 24, 2022
@VerteDinde VerteDinde deleted the bg-bv-background-16 branch May 24, 2022 16:29
@release-clerk
Copy link

release-clerk bot commented May 24, 2022

Release Notes Persisted

Fixed an issue with background colors being improperly applied to BrowserViews on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants