Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick 418c276ef228 from v8 #32194

Merged
merged 2 commits into from Dec 20, 2021
Merged

chore: cherry-pick 418c276ef228 from v8 #32194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c74d93a
chore: cherry-pick 418c276ef228 from v8
ppontes Dec 15, 2021
cef4d62
chore: update patches
patchup[bot] Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/v8/.patches
View file
Open in desktop
Expand Up @@ -22,3 +22,4 @@ merged_cppgc_fix_marking_of_ephemerons_with_keys_in_construction.patch
cherry-pick-feef10137b16.patch
cherry-pick-014e1f857c33.patch
cherry-pick-5d2b5e7c006c.patch
cherry-pick-418c276ef228.patch
40 changes: 40 additions & 0 deletions patches/v8/cherry-pick-418c276ef228.patch
View file
Open in desktop
@@ -0,0 +1,40 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Leszek Swirski <leszeks@chromium.org>
Date: Fri, 10 Dec 2021 15:56:05 +0100
Subject: Merged: [compiler] Don't elide
ChangeTaggedToInt32->ChangeInt31ToTaggedSigned

(cherry picked from commit 4fae8b16802a416fe3aab0e7792fabe96cf1ecd8)

(cherry picked from commit f4f11c23ae2eaf9bb4525d0fac7ab842de9b0fe2)

Bug: chromium:1278387
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9b89834c094510e064988aa534ec230309996034
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329665
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/9.6@{#40}
Cr-Original-Branched-From: 0b7bda016178bf438f09b3c93da572ae3663a1f7-refs/heads/9.6.180@{#1}
Cr-Original-Branched-From: 41a5a247d9430b953e38631e88d17790306f7a4c-refs/heads/main@{#77244}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3335759
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{#56}
Cr-Branched-From: 3b51863bc25492549a8bf96ff67ce481b1a3337b-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419fc8fb9bdb507fdd801d76fa7dd9f022b5-refs/heads/master@{#76233}

diff --git a/src/compiler/simplified-operator-reducer.cc b/src/compiler/simplified-operator-reducer.cc
index b1d3f8b2f3a544dbff02b493f3025ac525233ef1..f31a6c9a0321dfbf3d9926961a39b977fc3be5a7 100644
--- a/src/compiler/simplified-operator-reducer.cc
+++ b/src/compiler/simplified-operator-reducer.cc
@@ -75,7 +75,7 @@ Reduction SimplifiedOperatorReducer::Reduce(Node* node) {
case IrOpcode::kChangeInt32ToTagged: {
Int32Matcher m(node->InputAt(0));
if (m.HasResolvedValue()) return ReplaceNumber(m.ResolvedValue());
- if (m.IsChangeTaggedToInt32() || m.IsChangeTaggedSignedToInt32()) {
+ if (m.IsChangeTaggedSignedToInt32()) {
return Replace(m.InputAt(0));
}
break;