Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 418c276ef228 from v8 #32194

Merged
merged 2 commits into from Dec 20, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 15, 2021

Merged: [compiler] Don't elide ChangeTaggedToInt32->ChangeInt31ToTaggedSigned

(cherry picked from commit 4fae8b16802a416fe3aab0e7792fabe96cf1ecd8)

(cherry picked from commit f4f11c23ae2eaf9bb4525d0fac7ab842de9b0fe2)

Bug: chromium:1278387
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9b89834c094510e064988aa534ec230309996034
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329665
Reviewed-by: Toon Verwaest verwaest@chromium.org
Cr-Original-Commit-Position: refs/branch-heads/9.6@{#40}
Cr-Original-Branched-From: 0b7bda016178bf438f09b3c93da572ae3663a1f7-refs/heads/9.6.180@{#1}
Cr-Original-Branched-From: 41a5a247d9430b953e38631e88d17790306f7a4c-refs/heads/main@{#77244}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3335759
Commit-Queue: Leszek Swirski leszeks@chromium.org
Owners-Override: Leszek Swirski leszeks@chromium.org
Cr-Commit-Position: refs/branch-heads/9.4@{#56}
Cr-Branched-From: 3b51863bc25492549a8bf96ff67ce481b1a3337b-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419fc8fb9bdb507fdd801d76fa7dd9f022b5-refs/heads/master@{#76233}

Notes: Backported fix for CVE-2021-4102.

@ppontes ppontes requested a review from a team as a code owner December 15, 2021 17:40
@ppontes ppontes added 13-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Dec 15, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 15, 2021
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - do we also need a patch for this in 15-x-y?

@ppontes
Copy link
Member Author

ppontes commented Dec 17, 2021

Just checking - do we also need a patch for this in 15-x-y?

No, Chromium backported it to M94: https://chromium-review.googlesource.com/c/v8/v8/+/3335759. We do need to roll Chromium and release 15-x-y.

@zcbenz zcbenz merged commit ca112e2 into 13-x-y Dec 20, 2021
@zcbenz zcbenz deleted the cherry-pick/13-x-y/v8/418c276ef228 branch December 20, 2021 03:45
@release-clerk
Copy link

release-clerk bot commented Dec 20, 2021

Release Notes Persisted

Backported fix for CVE-2021-4102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants