Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <webview> background transparency #31722

Merged
merged 1 commit into from Nov 6, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Nov 4, 2021

Description of Change

Fixes #31686 regressed by #30777

Checklist

Release Notes

Notes: Fixed <webview> background transparency regression.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 4, 2021
@miniak
Copy link
Contributor Author

miniak commented Nov 4, 2021

I am hitting this DCHECK when running this code change with a testing build:

FATAL:render_widget_host_view_child_frame.cc(311)] Check failed: SkColorGetA(color) == SK_AlphaOPAQUE || SkColorGetA(color) == SK_AlphaTRANSPARENT.

RenderWidgetHostViewChildFrame::UpdateBackgroundColor()

Everything works properly however when I comment out the DCHECK or run the release build.
The color is actually #ff000080, which I am setting in CSS in the Fiddle repro in the bug-report.

@miniak miniak self-assigned this Nov 4, 2021
@miniak miniak added target/16-x-y semver/patch backwards-compatible bug fixes labels Nov 4, 2021
@miniak miniak marked this pull request as ready for review November 4, 2021 23:12
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 5, 2021
@VerteDinde VerteDinde merged commit 95a867b into main Nov 6, 2021
@VerteDinde VerteDinde deleted the miniak/webview-background-transparency branch November 6, 2021 02:55
@release-clerk
Copy link

release-clerk bot commented Nov 6, 2021

Release Notes Persisted

Fixed &lt;webview&gt; background transparency regression.

@trop
Copy link
Contributor

trop bot commented Nov 6, 2021

I have automatically backported this PR to "16-x-y", please check out #31728

@TanninOne
Copy link
Contributor

@miniak This bug also exists in 15-x-y (and 14-x-y afaik) could this be backported to those versions as well?

@zcbenz
Copy link
Member

zcbenz commented Nov 14, 2021

/trop run backport

@trop
Copy link
Contributor

trop bot commented Nov 14, 2021

The backport process for this PR has been manually initiated - here we go! :D

@trop
Copy link
Contributor

trop bot commented Nov 14, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Nov 14, 2021
@trop
Copy link
Contributor

trop bot commented Nov 14, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: <webview> transparency broken
5 participants