Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Vibrancy + Transparent background still broken on macOS on 16.0.0 #31862

Closed
3 tasks done
theolivenbaum opened this issue Nov 16, 2021 · 2 comments · Fixed by #32593
Closed
3 tasks done

[Bug]: Vibrancy + Transparent background still broken on macOS on 16.0.0 #31862

theolivenbaum opened this issue Nov 16, 2021 · 2 comments · Fixed by #32593
Assignees
Labels
14-x-y 15-x-y 16-x-y 17-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS
Projects

Comments

@theolivenbaum
Copy link

Preflight Checklist

Electron Version

16.0.0

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.0.1

What arch are you using?

x64

Last Known Working Electron version

n/a

Expected Behavior

Window does not have a white background when vibrancy is set to under-window + transparent background is used on macOS

Actual Behavior

Window with vibrancy and transparency enabled is rendered with a white background, at random

Testcase Gist URL

No response

Additional Information

We're still hitting random issues with Electron where creating a window with vibrancy + transparent body will result in a white background. I was hopeful that the 16.0.0 release would have fixed this as it was mentioned in the changelog, but seems like the issue persists.

I've tried to narrow down to a reproducible case, but didn't manage to do so - I've observed all these variations across executions:

  • Window opens with correct vibrancy effect, and it works without issues
  • Windows opens with correct vibrancy effect then goes white after ~4 seconds - consistently after ~4 seconds
  • Window opens with correct vibrancy, stays without issues, but loses after some time of switching between apps
  • Windows open with effect already not working and a white background

I've already tried all suggestions from previous issues like #30993 or #31461 . The window is created with vibrancy set to under-window, has a transparent background and the webpreferences also has a transparent background set. As it works sometimes, I assume the options here are correct.

My guess is that this is somehow related to #31019: Electron is using somehow the background color of the HTML body. As we initially load the window with about:empty, then navigate to our url, the transparent background logic might be loading the incorrect background color at random times and breaking the transparency/vibrancy effect from there on.

I also don't know if #31722 is already merged on the 16.0.0 release - happy to test if not the case once it is again!

@theolivenbaum
Copy link
Author

@theolivenbaum theolivenbaum changed the title [Bug]: Vibrancy + Transparent background still broken on macOS o 16.0.0 [Bug]: Vibrancy + Transparent background still broken on macOS on 16.0.0 Nov 16, 2021
@ckerr ckerr added 16-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS labels Nov 16, 2021
@mlaurencin mlaurencin added this to Unsorted Issues in 17-x-y Nov 17, 2021
@sofianguy sofianguy moved this from Unsorted Issues to Does Not Block Stable in 17-x-y Nov 18, 2021
@codebytere codebytere self-assigned this Jan 10, 2022
@codebytere codebytere moved this from Does Not Block Stable to Blocks Stable in 17-x-y Jan 19, 2022
@codebytere
Copy link
Member

This issue has changed behavior as of v17.0.0-beta.2...v17.0.0-beta.3, which i narrowed down further to the Chromium roll. It now won't change to transparent at all, instead staying green for the duration.

@VerteDinde VerteDinde moved this from Blocks Stable to Fixed For Next Release in 17-x-y Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y 15-x-y 16-x-y 17-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS
Projects
17-x-y
Fixed For Next Release
Development

Successfully merging a pull request may close this issue.

4 participants