Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate valid config.gypi #31443

Merged
merged 2 commits into from Oct 18, 2021
Merged

fix: generate valid config.gypi #31443

merged 2 commits into from Oct 18, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Oct 15, 2021

Backport of #31404.

Notes: Generate valid config.gypi file in Node.js headers.

@zcbenz zcbenz requested a review from a team as a code owner October 15, 2021 00:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 15, 2021
@trop trop bot mentioned this pull request Oct 15, 2021
Merged
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 15, 2021
@ckerr
Copy link
Member

ckerr commented Oct 18, 2021

electron-woa-testing failure looks unrelated

@ckerr ckerr merged commit c5a7ccc into 14-x-y Oct 18, 2021
@ckerr ckerr deleted the valid-config-gypi-14 branch October 18, 2021 17:20
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2021

Release Notes Persisted

Generate valid config.gypi file in Node.js headers.

@jkleinsc
Copy link
Contributor

/trop run backport-to 13-x-y

@trop
Copy link
Contributor

trop bot commented Nov 24, 2021

The backport process for this PR has been manually initiated - sending your PR to 13-x-y!

@trop
Copy link
Contributor

trop bot commented Nov 24, 2021

I have automatically backported this PR to "13-x-y", please check out #31989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @ckerr @jkleinsc