fix: generate valid config.gypi #31404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🥇 |
codebytere
approved these changes
Oct 14, 2021
jkleinsc
approved these changes
Oct 14, 2021
|
Merging as CI failure is known flake unrelated to PR change. |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "14-x-y" cleanly; |
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I was unable to backport this PR to "16-x-y" cleanly; |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently Electron generates a malformed
config.gypifile in Node headers, which is fine since it is actually ignored by node-gyp when building modules.However with nodejs/node-gyp#2497, the
config.gypifile in Node headers is going to be respected, and with it we will finally be able to get rid of our patches on Node'scommon.gypifile. And to make Electron's Node headers work correctly with node-gyp, we must generated a validconfig.gypifile.Release Notes
Notes: Generate valid config.gypi file in Node.js headers.