Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commandLine.removeSwitch #31327

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 6, 2021

Backport of #30933

See that PR for details.

Notes: Added commandLine.removeSwitch to allow apps to remove command line switches from Chromiums internal command line representation

MarshallOfSound and others added 2 commits October 6, 2021 20:46
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 6, 2021
@trop trop bot requested a review from MarshallOfSound October 6, 2021 20:46
@trop trop bot added 16-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Oct 6, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 6, 2021
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases

@zcbenz zcbenz merged commit 6530067 into 16-x-y Oct 12, 2021
@zcbenz zcbenz deleted the trop/16-x-y-bp-feat-add-commandline-removeswitch-1633553174544 branch October 12, 2021 00:06
@release-clerk
Copy link

release-clerk bot commented Oct 12, 2021

Release Notes Persisted

Added commandLine.removeSwitch to allow apps to remove command line switches from Chromiums internal command line representation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants