-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add commandLine.removeSwitch #30933
Conversation
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM but you forgot a line in app.ts
electron/lib/browser/api/app.ts Lines 37 to 44 in 93068cf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like newly added test is failing
@jkleinsc the tests are now passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good to me.
@jkleinsc this PR can be merged now, everything is green |
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #31326 |
I have automatically backported this PR to "16-x-y", please check out #31327 |
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add commandLine.removeSwitch In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher * fix: add missing removeSwitch to app.ts Co-authored-by: Milan Burda <milan.burda@gmail.com>
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
Notes: Added
commandLine.removeSwitch
to allow apps to remove command line switches from Chromiums internal command line representation