Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in v8 due to regexp reentrancy #31102

Merged
merged 2 commits into from Sep 27, 2021
Merged

fix: crash in v8 due to regexp reentrancy #31102

merged 2 commits into from Sep 27, 2021

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Sep 23, 2021 •
edited

Description of Change

More-info in https://bugs.chromium.org/p/chromium/issues/detail?id=1250646
Refs https://bugs.chromium.org/p/v8/issues/detail?id=11382

Refs microsoft/vscode#122225

Checklist

Release Notes

Notes: fix crash in v8 due to (Check failed: !regexp_stack_->is_in_use())

@deepak1556 deepak1556 requested a review from a team as a code owner September 23, 2021 22:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2021
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/13-x-y labels Sep 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 24, 2021
@codebytere codebytere merged commit 68c738a into main Sep 27, 2021
@codebytere codebytere deleted the robo/fix_reentrant_regexp branch September 27, 2021 14:58
@release-clerk
Copy link

release-clerk bot commented Sep 27, 2021

Release Notes Persisted

fix crash in v8 due to (Check failed: !regexp_stack_->is_in_use())

This was referenced Sep 27, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 27, 2021

I have automatically backported this PR to "13-x-y", please check out #31142

@trop trop bot mentioned this pull request Sep 27, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 27, 2021

I have automatically backported this PR to "14-x-y", please check out #31143

@trop trop bot removed the target/13-x-y label Sep 27, 2021
@trop
Copy link
Contributor

trop bot commented Sep 27, 2021

I have automatically backported this PR to "15-x-y", please check out #31144

@trop trop bot mentioned this pull request Sep 27, 2021
Merged
@trop trop bot removed the target/15-x-y label Sep 27, 2021
@trop
Copy link
Contributor

trop bot commented Sep 27, 2021

I have automatically backported this PR to "16-x-y", please check out #31145

@commit-lint commit-lint bot mentioned this pull request Dec 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere