Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in v8 due to regexp reentrancy #31144

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 27, 2021

Backport of #31102

See that PR for details.

Notes: fix crash in v8 due to (Check failed: !regexp_stack_->is_in_use())

@trop trop bot requested a review from a team as a code owner September 27, 2021 14:59
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2021
@trop trop bot requested a review from deepak1556 September 27, 2021 14:59
@trop trop bot mentioned this pull request Sep 27, 2021
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2021
@deepak1556
Copy link
Member

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit 45813a0 into 15-x-y Sep 27, 2021
@deepak1556 deepak1556 deleted the trop/15-x-y-bp-fix-crash-in-v8-due-to-regexp-reentrancy-1632754746319 branch September 27, 2021 23:54
@release-clerk
Copy link

release-clerk bot commented Sep 27, 2021

Release Notes Persisted

fix crash in v8 due to (Check failed: !regexp_stack_->is_in_use())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants