Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Windows' cache after changing window's style #31021

Merged
merged 1 commit into from Sep 23, 2021

Conversation

CezaryKulakowski
Copy link
Contributor

@CezaryKulakowski CezaryKulakowski commented Sep 20, 2021

To enable/disable window resizing we set/unset WS_THICKFRAME style
flag on the window. Window's frame styles are cached so we need to
call SetWindowPos with the SWP_FRAMECHANGED flag set to update
cache properly.

Issue: #31020

Description of Change

Checklist

Release Notes

Notes: fixed black border around the page after resizing is disabled

To enable/disable window resizing we set/unset WS_THICKFRAME style
flag on the window. Window's frame styles are cached so we need to
call SetWindowPos with the SWP_FRAMECHANGED flag set to update
cache properly.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 20, 2021
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/12-x-y labels Sep 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2021
@zcbenz zcbenz merged commit 68d3659 into electron:main Sep 23, 2021
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2021

Release Notes Persisted

fixed black border around the page after resizing is disabled

@trop
Copy link
Contributor

trop bot commented Sep 23, 2021

I have automatically backported this PR to "13-x-y", please check out #31078

@trop
Copy link
Contributor

trop bot commented Sep 23, 2021

I have automatically backported this PR to "14-x-y", please check out #31079

@trop
Copy link
Contributor

trop bot commented Sep 23, 2021

I have automatically backported this PR to "16-x-y", please check out #31080

@trop
Copy link
Contributor

trop bot commented Sep 23, 2021

I have automatically backported this PR to "15-x-y", please check out #31081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants