Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Windows' cache after changing window's style #31080

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 23, 2021

Backport of #31021

See that PR for details.

Notes: fixed black border around the page after resizing is disabled

To enable/disable window resizing we set/unset WS_THICKFRAME style
flag on the window. Window's frame styles are cached so we need to
call SetWindowPos with the SWP_FRAMECHANGED flag set to update
cache properly.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2021
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2021
@zcbenz zcbenz merged commit f6da3b4 into 16-x-y Sep 23, 2021
@zcbenz zcbenz deleted the trop/16-x-y-bp-fix-update-windows-cache-after-changing-window-s-style-1632382439940 branch September 23, 2021 10:48
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2021

Release Notes Persisted

fixed black border around the page after resizing is disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants