Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'dom-ready' event to WebFrameMain #30801

Commits on Sep 1, 2021

  1. feat: add 'frame-dom-ready' event to WebContents

    fix: test failing possibly caused by lazy loaded iframes?
    
    refactor: move frame-dom-ready event into WebFrameMain
    
    test: new WebFrameMain dom-ready event
    
    refactor: return bool
    
    refactor: add gin_helper::AccessorValue for gin accessor conversion
    
    refactor: call methods directly from electron:WebContents
    
    Writing static method boilerplate isn't fun
    
    feat: add WebFrameMain 'destroyed' event
    
    Update shell/common/gin_converters/frame_converter.cc
    
    Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
    
    refactor: use persistent handle for rfh obj template
    
    docs: when the WebFrameMain 'destroyed' event can occur
    
    refactor: use dcheck and 'As' instead of 'Cast'
    
    chore: add type checking to internal fields
    
    refactor: add conditional for internal field count
    
    refactor: removed 'destroyed event and isDestroyed()
    
    This may be revisited at a later time.
    
    test: frame-created event
    samuelmaddock authored and electron-bot committed Sep 1, 2021
    Copy the full SHA
    563a7fb View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    72dd3b0 View commit details
    Browse the repository at this point in the history
  3. fix: remove CHECK_EQ for swapped RFH

    |old_host| may be nullptr if the previous RFH was shutdown.
    samuelmaddock authored and electron-bot committed Sep 1, 2021
    Copy the full SHA
    0082b19 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    4563a9b View commit details
    Browse the repository at this point in the history
  5. doc: omit event object

    samuelmaddock authored and electron-bot committed Sep 1, 2021
    Copy the full SHA
    b3991d6 View commit details
    Browse the repository at this point in the history